Thread notes #104
Thread notes #104
Conversation
| @message_thread = message_thread | ||
| @thread_tags_with_deletable_flag = thread_tags_with_deletable_flag | ||
| @thread_messages = thread_messages | ||
| @message_thread_note = message_thread_note |
There was a problem hiding this comment.
toto vies vytiahnut z @message_thread cize netreba explicitne posielat. sice to odpali select ale N+1 query problem nehrozi takze nevidim problem.
There was a problem hiding this comment.
OK, cize ked nejde cez to iterovat, alebo nepouzivame ako kolekciu, tak si to neposielame. To je asi dobre pravidlo.
| return unless @message_thread_note.last_updated_at | ||
|
|
||
| @formatted_last_updated_at = l @message_thread_note.last_updated_at, format: :long |
There was a problem hiding this comment.
Toto je best practice? nemali by taketo formatovacie veci byt vo view?
There was a problem hiding this comment.
Neviem, ci je, resp. asi nie je. Zdalo sa mi to ako prilis komplikovany vyraz na to, aby som ho nechal vo viewe, najprv bol totiz tam. Este mozme pouzit jednu z tych verzii helpera, ktoru diskutujeme v inom vlakne. Si asi vyber.
There was a problem hiding this comment.
No praveze taketo sa bezne do view dava
app/models/message_thread.rb
Outdated
|
|
||
| thread.reload | ||
| thread.destroy! | ||
| thread.merge_identifiers.update_all(message_thread_id: target_thread.id) |
There was a problem hiding this comment.
Sorry, este par krat mi to spravi, a vypnem ho. Zatial mam ale stale rad tie jeho obcasne navrhy na zlepsenia, co prinasa
app/models/message_thread_note.rb
Outdated
| @@ -0,0 +1,15 @@ | |||
| # == Schema Information | |||
| # | |||
| # Table name: message_threads | |||
| create_table :message_thread_notes do |t| | ||
| t.references :message_thread, null: false, foreign_key: true | ||
| t.text :note | ||
| t.datetime :last_updated_at, null: false |
There was a problem hiding this comment.
pokial nemame usecase na specialny last_updated_at tak pouzivajme ten defaultny.
|
Ten UX necham ale chalanom doladit. Zatial som spravil aspon to, aby to bolo defaultne rozbalene, ked poznamka existuje. @jsuchal |
app/models/message_thread.rb
Outdated
| return unless message_thread_note&.note | ||
|
|
||
| if target_thread.message_thread_note | ||
| join_string = "\nPripojené z vlákna #{title} #{I18n.l DateTime.now, format: :long}:\n" |
There was a problem hiding this comment.
Toto takto nie, rozbije sa to na prekladoch. Ja by som tam dal len nejaky separator --- a hotovo.
Otazky, resp. dilemy